Skip to content

Conversation

@pingtimeout
Copy link
Contributor

We are being rate limited by medium and that fails the check markdown-link-check. Problem: the release workflows currently require all checks to pass. This commit skips the verification for the markdown-link-check.

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Nov 21, 2025
@dimas-b
Copy link
Contributor

dimas-b commented Nov 21, 2025

Related PR: #3102


local num_invalid_checks
local num_invalid_checks_retrieval_command="gh api repos/${repo_info}/commits/${commit_sha}/check-runs --jq '[.check_runs[] | select(.conclusion != \"success\" and .conclusion != \"skipped\" and (.name | startswith(\"Release - \") | not))] | length'"
local num_invalid_checks_retrieval_command="gh api repos/${repo_info}/commits/${commit_sha}/check-runs --jq '[.check_runs[] | select(.conclusion != \"success\" and .conclusion != \"skipped\" and (.name | startswith(\"Release - \") | not) and (.name != \"markdown-link-check\"))] | length'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably more flexible.
We already have the name of the required checks in .asf.yaml, and can get the names as a JSON array via yq (available on GH runners).

Suggested change
local num_invalid_checks_retrieval_command="gh api repos/${repo_info}/commits/${commit_sha}/check-runs --jq '[.check_runs[] | select(.conclusion != \"success\" and .conclusion != \"skipped\" and (.name | startswith(\"Release - \") | not) and (.name != \"markdown-link-check\"))] | length'"
local required_check_names_array="$(yq -o json '.github.protected_branches.main.required_status_checks.contexts' < .asf.yaml)"
#
local num_invalid_checks_retrieval_command="$(gh api repos/${repo_info}/commits/${commit_sha}/check-runs --jq "
[
.check_runs[] |
select(
.conclusion != \"success\" and
.conclusion != \"skipped\" and
(
.name as \$name |
any(
${required_check_names_array}[] == \$name
)
)
)
]
| length
")"

The yq command yields:

[
  "Unit Tests",
  "Quarkus Tests",
  "Quarkus Integration Tests",
  "Quarkus Admin Tests",
  "Integration Tests",
  "regtest",
  "spark-plugin-regtest",
  "site",
  "Helm tests"
]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to run a full release cycle before merging this, and that requires all CI checks to pass (>20 minutes) plus another 20 minutes to fully package Polaris and its components. Let's open a separate PR for that so that I can merge this PR and release 1.3.0 in about 45 minutes.

@pingtimeout pingtimeout merged commit 2e4f42f into apache:main Nov 24, 2025
14 of 15 checks passed
@pingtimeout pingtimeout deleted the release-workflow-skip-checks branch November 24, 2025 09:56
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants