Skip to content

Conversation

@MonkeyCanCode
Copy link
Contributor

Description

There are couple additional non-optional parameters introduced for the last one month such as "io.factoryType" which can actually cause issue while using Polaris. This PR is to sync what is currently available in https://github.com/apache/polaris/blob/main/polaris-server.yml to the one ref by the helm.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Create a fresh Kind cluster via run.sh then install via Helm to ensure no error raise during install.

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue

sfc-gh-emaynard

This comment was marked as duplicate.

@eric-maynard
Copy link
Contributor

LGTM!

I would actually like us to add more null-checks for things like a missing io, but I tried doing it with Valid and NotNull annotations but didn't have much success.

This doesn't need to block us here. Let's fix the config first.

@eric-maynard
Copy link
Contributor

Thanks for the fix!

@eric-maynard eric-maynard merged commit ce7d2f0 into apache:main Sep 25, 2024
@MonkeyCanCode MonkeyCanCode deleted the fix_155_helm branch December 12, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants