Using case insensitive storage type names #3349
Open
+339
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #996 and ensures that catalogs can be created or updated with lower case/ case insensitive characters. The change short circuits the de-serialization process to make everything storage type upper case before continuing on de-serialization.
How I tested the change:
Other tests ran
Integration test with ./gradlew :polaris-runtime-service:intTest --tests "ManagementServiceIT.*"
all tests passed
ran regtests with env POLARIS_HOST=localhost ./regtests/run.sh
all tests also passed.
The one thing I am still a bit skeptical about is performance. I would expect the impact to be minimal given that payloads are usually small. However, it would be nice to have some sort of benchmark to run against the change.
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)