Skip to content

Conversation

@evindj
Copy link

@evindj evindj commented Jan 3, 2026

This PR addresses issue #996 and ensures that catalogs can be created or updated with lower case/ case insensitive characters. The change short circuits the de-serialization process to make everything storage type upper case before continuing on de-serialization.

How I tested the change:

  • Added unit tests for case insensitive StorageConfigInfo.
  • Added tests for creating/updating catalogs with case insensitive storage types

Other tests ran
Integration test with ./gradlew :polaris-runtime-service:intTest --tests "ManagementServiceIT.*"
all tests passed
ran regtests with env POLARIS_HOST=localhost ./regtests/run.sh
all tests also passed.

The one thing I am still a bit skeptical about is performance. I would expect the impact to be minimal given that payloads are usually small. However, it would be nice to have some sort of benchmark to run against the change.

Checklist

  • 🛡️ Don't disclose security issues! (contact security@apache.org)
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic
  • 🧾 Updated CHANGELOG.md (if needed)
  • 📚 Updated documentation in site/content/in-dev/unreleased (if needed)

@github-project-automation github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Jan 3, 2026
@evindj evindj marked this pull request as draft January 3, 2026 16:31
@evindj evindj changed the title Initial attempt to make deserializer tolerate case insensitivity for … Using case insensitive storage type names Jan 4, 2026
@evindj evindj marked this pull request as ready for review January 4, 2026 03:44
@dimas-b
Copy link
Contributor

dimas-b commented Jan 5, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants