Skip to content

Conversation

@evindj
Copy link
Contributor

@evindj evindj commented Jan 26, 2026

This PR addresses issue #3418 after this PR recently did the same for tables.
Given that the current implementation of commitTransaction works only for table (from my reading, please correct if I am wrong), I concluded only removing events would be enough especially since *ReplaceView is already supported.

Tests:

Ran integration tests.

Checklist

  • 🛡️ Don't disclose security issues! (contact security@apache.org)
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic
  • 🧾 Updated CHANGELOG.md (if needed)
  • 📚 Updated documentation in site/content/in-dev/unreleased (if needed)

@evindj
Copy link
Contributor Author

evindj commented Jan 26, 2026

@snazy please have a look. I closed #3441 in favor of this after mixing up the rebase.

@dimas-b dimas-b requested review from adutra and snazy January 26, 2026 22:48
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM!

In the future, please just rebase the existing PR (#3441) instead of opening a new one.

@github-project-automation github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Jan 27, 2026
AFTER_REPLACE_VIEW,
BEFORE_COMMIT_VIEW,
AFTER_COMMIT_VIEW,
BEFORE_COMMIT_VIEW, // REMOVED FROM SOURCE CODE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm catching up here and saw this related conversation:

https://github.com/apache/polaris/pull/3195/changes#r2593440033

I'm not sure I agree with keeping these constants. Granted the ordinals will change if we remove them. But the feature is in beta status right now. It feels odd to see deprecated/unused constants in an API that is not even "official" yet.

@adnanhemani @dimas-b what do you think?

Copy link
Contributor

@dimas-b dimas-b Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see any particular issue with changing ordinals. AFAIK, Polaris does not use java serialization for this enum and Jackson deals with names.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are to remove the constants, will be ok doing in a follow up PR?cc @adutra I can take ownership of that issue as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think doing it in a separate PR makes sense, so the two other similar enum values can be removed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants