Correct build instruction, project properties require org.gradle.project prefix#3680
Merged
dimas-b merged 2 commits intoapache:mainfrom Feb 6, 2026
Merged
Conversation
jbonofre
previously approved these changes
Feb 5, 2026
Member
|
Good catch. |
Member
|
Thanks ! |
dimas-b
reviewed
Feb 5, 2026
extensions/federation/hive/README.md
Outdated
| The other option is to pass it as an argument to the gradle JVM as follows: | ||
| ``` | ||
| ./gradlew build -DNonRESTCatalogs=HIVE | ||
| ./gradlew build -Dorg.gradle.project.NonRESTCatalogs=HIVE |
Contributor
There was a problem hiding this comment.
Should it be -PNonRESTCatalogs=HIVE perhaps?
Cf. https://docs.gradle.org/current/userguide/build_environment.html
Contributor
There was a problem hiding this comment.
The new -D works too, but -P seems to be clearer 🤔
Contributor
Author
There was a problem hiding this comment.
Yep, -P also works. Let me replace it to -P.
dimas-b
approved these changes
Feb 6, 2026
Contributor
dimas-b
left a comment
There was a problem hiding this comment.
Thanks, @nandorKollar !
I assume @jbonofre 's previous approval holds for -P too 🙂 so I'm merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor doc fix for the build command in the federated metastore instructions: it appears project properties neer the 'org.gradle.project' prefix to work correctly.
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)