Update Spark Plugin BUNDLE-LICENSE/NOTICE for 1.4.0#3909
Update Spark Plugin BUNDLE-LICENSE/NOTICE for 1.4.0#3909snazy wants to merge 3 commits intoapache:mainfrom
Conversation
jbonofre
left a comment
There was a problem hiding this comment.
There are a few mistakes in the PR.
In the meantime, I'm doing a full pass on the spark plugin (uber jar).
|
@jbonofre I've pushed an update via the The 3rd commit is a different approach by "just" copying the contents of the |
jbonofre
left a comment
There was a problem hiding this comment.
Some comments:
- I would rephrase the Iceberg "documentation" as
This product bundles and includes code from Apache Iceberg. Same for Apache Spark. - JCTools (shaded in Netty) should be documented in the
LICENSEfile. - Apache DataSketches (shaded in Iceberg) should be documented in the
LICENSEfile. - OpenHFT Hashing (shaded in Parquet, shaded in Iceberg) should be documented in the
LICENSEfile. - RoaringBitmap (shaded in Iceberg) should be documented in the
LICENSEfile. - Eclipse Collection (shaded) should be documented in the
LICENSEfile. - LocationTech JTS (shaded) should be documented in the
LICENSEfile. - I don't see JavaFastPFOR wrapped anymore in the bundle jar. So it can be removed from the
LICENSEfile. - Apache Hive (api) can be removed from the
LICENSEfile as it's not shaded by ORC anymore. - Protobuf can be removed from the
LICENSEfile as it's not shaded by ORC anymore.
| -------------------------------------------------------------------------------- | ||
|
|
||
| This binary artifact contains Apache Iceberg. | ||
| ******************************************************************************** |
There was a problem hiding this comment.
I would remove this section (just to avoid to "pollute" the LICENSE file).
| Copyright: 2014 and onwards The Apache Software Foundation | ||
| Project URL: https://spark.apache.org/ | ||
| License: Apache License 2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt | ||
| Copyright: Copyright 2010-2019 The Apache Software Foundation |
There was a problem hiding this comment.
NB: the copyright is not strictly required copyright here.
|
Hm - the issues are interesting, the 3rd commit in this PR represents an exact copy of the contents of Iceberg's LICENSE+NOTICE files from the bundle jar. |
Fixes #3873