Skip to content

Update Spark Plugin BUNDLE-LICENSE/NOTICE for 1.4.0#3909

Open
snazy wants to merge 3 commits intoapache:mainfrom
snazy:plugin-lic-not
Open

Update Spark Plugin BUNDLE-LICENSE/NOTICE for 1.4.0#3909
snazy wants to merge 3 commits intoapache:mainfrom
snazy:plugin-lic-not

Conversation

@snazy
Copy link
Member

@snazy snazy commented Feb 28, 2026

Fixes #3873

@snazy snazy requested a review from jbonofre February 28, 2026 10:33
@github-project-automation github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Feb 28, 2026
@snazy snazy added this to the 1.4.0 milestone Feb 28, 2026
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few mistakes in the PR.

In the meantime, I'm doing a full pass on the spark plugin (uber jar).

@snazy
Copy link
Member Author

snazy commented Feb 28, 2026

@jbonofre I've pushed an update via the review commit.

The 3rd commit is a different approach by "just" copying the contents of the iceberg-spark-runtime.jar's LICENSE + NOTICE files. I'd expect those to be legally correct. As the iceberg-spark-runtime.jar is the only dependency that the plugin pulls in, it should be sufficient. WDYT?

Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments:

  1. I would rephrase the Iceberg "documentation" as This product bundles and includes code from Apache Iceberg. Same for Apache Spark.
  2. JCTools (shaded in Netty) should be documented in the LICENSE file.
  3. Apache DataSketches (shaded in Iceberg) should be documented in the LICENSE file.
  4. OpenHFT Hashing (shaded in Parquet, shaded in Iceberg) should be documented in the LICENSE file.
  5. RoaringBitmap (shaded in Iceberg) should be documented in the LICENSE file.
  6. Eclipse Collection (shaded) should be documented in the LICENSE file.
  7. LocationTech JTS (shaded) should be documented in the LICENSE file.
  8. I don't see JavaFastPFOR wrapped anymore in the bundle jar. So it can be removed from the LICENSE file.
  9. Apache Hive (api) can be removed from the LICENSE file as it's not shaded by ORC anymore.
  10. Protobuf can be removed from the LICENSE file as it's not shaded by ORC anymore.

--------------------------------------------------------------------------------

This binary artifact contains Apache Iceberg.
********************************************************************************
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this section (just to avoid to "pollute" the LICENSE file).

Copyright: 2014 and onwards The Apache Software Foundation
Project URL: https://spark.apache.org/
License: Apache License 2.0 - https://www.apache.org/licenses/LICENSE-2.0.txt
Copyright: Copyright 2010-2019 The Apache Software Foundation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: the copyright is not strictly required copyright here.

@snazy
Copy link
Member Author

snazy commented Mar 5, 2026

Hm - the issues are interesting, the 3rd commit in this PR represents an exact copy of the contents of Iceberg's LICENSE+NOTICE files from the bundle jar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LICENSE + NOTICE for Spark plugin are missing dependencies

2 participants