fix(helm): add quarkus.http.cors.enabled=true when CORS is configured#3931
Merged
adutra merged 3 commits intoapache:mainfrom Mar 5, 2026
Merged
fix(helm): add quarkus.http.cors.enabled=true when CORS is configured#3931adutra merged 3 commits intoapache:mainfrom
adutra merged 3 commits intoapache:mainfrom
Conversation
adutra
reviewed
Mar 4, 2026
adutra
reviewed
Mar 4, 2026
adutra
reviewed
Mar 4, 2026
adutra
approved these changes
Mar 4, 2026
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
Contributor
|
@dimas-b do you think this deserves a mention in the changelog? |
Contributor
|
It's a bugfix, right? CORS support was added before, just did not work, right? I do not think we have to mention all bugfixes in CHANGELOG, but it won't hurt either :) |
dimas-b
approved these changes
Mar 4, 2026
Contributor
|
On the other hand, we're adding a new helm flag, so it might be worth a brief line in CHANGELOG :) |
nandorKollar
approved these changes
Mar 4, 2026
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
Contributor
|
Thanks @ddecrulle for your contribution! @dimas-b I will update the changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Helm chart CORS configuration that was silently ignored by Quarkus because quarkus.http.cors.enabled=true was never generated.
Fixes #3930
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)