Service: Refactor on grant operation#4059
Merged
flyrain merged 2 commits intoapache:mainfrom Mar 26, 2026
Merged
Conversation
github-project-automation
bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
github-project-automation
bot
moved this from Done
to PRs In Progress
in Basic Kanban Board
dimas-b
approved these changes
Mar 25, 2026
Comment on lines
+635
to
+639
| direction == GrantDirection.GRANT | ||
| ? adminService.grantPrivilegeOnViewToRole( | ||
| catalogName, catalogRoleName, identifier, privilege) | ||
| : adminService.revokePrivilegeOnViewFromRole( | ||
| catalogName, catalogRoleName, identifier, privilege); |
Contributor
There was a problem hiding this comment.
nit: pls consider adding helper methods to the enum then : direction.applyToView(adminService, catalogName, catalogRoleName, identifier, privilege). This would be more readable, IMHO.
Contributor
Author
There was a problem hiding this comment.
Tried locally. It turns out removing 20 lines of code by adding 80 LOC. Net negative. Not sure if it's worth to pursue, but I'm open to suggestion
Contributor
There was a problem hiding this comment.
Interesting 🤔 No worries, let's skip that.
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor on the grant operation to reduce code duplication.
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)