Rename ExternalCatalogFactory to FederatedCatalogFactory#4116
Merged
flyrain merged 2 commits intoapache:mainfrom Apr 3, 2026
Merged
Rename ExternalCatalogFactory to FederatedCatalogFactory#4116flyrain merged 2 commits intoapache:mainfrom
flyrain merged 2 commits intoapache:mainfrom
Conversation
dimas-b
previously approved these changes
Apr 3, 2026
6 tasks
jbonofre
previously approved these changes
Apr 3, 2026
Member
jbonofre
left a comment
There was a problem hiding this comment.
I also suggest to rename createExternalCatalogFactory() method in AbstractIcebergCatalogHandlerAuthzTest.
Co-authored-by: JB Onofré <jbonofre@apache.org>
Contributor
Author
jbonofre
approved these changes
Apr 3, 2026
Member
|
@flyrain oh yes, sorry I was confused by the similar names 😄 |
dimas-b
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename ExternalCatalogFactory to FederatedCatalogFactory because "external catalog" is a broader concept than what this interface represents. An external catalog can be either:
This factory interface only applies to the first case: it takes a ConnectionConfigInfoDpo and creates a remote catalog handle. Naming it ExternalCatalogFactory incorrectly implies
it covers all external catalog types. FederatedCatalogFactory makes the scope clear and is consistent with its existing implementations (HiveFederatedCatalogFactory,
HadoopFederatedCatalogFactory).
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)