Open
Conversation
Zizmor is a static analysis toll, which, by the nature of such tools, does not consider the context of a finding, but judges on using static patters. Users can either deal with false positives or silence a lot to a level that they don't report much by default. Hiding those can, in case of security issues, be dangerous. 'low' confidence doesn't mean that the risk does not exist nor that the issue is not exploitable. 'informational'/'low' severity issues today can become 'high' or even 'critical' ones tomorrow. Hiding those can easily give a false sense of security. Chains of informational/low severity/confidence issues have led to exactly the recent tj-actions incident. Some of these are: * unpinned actions: this is _still_ a risk, just look at the [approved wildcard patterns](https://github.com/apache/infrastructure-actions/blob/8a059befd17ed98f4942c5cf3a67b7378045b669/approved_patterns.yml). * no explicitly declared workflow/job permissions - this is even just _informational_ * similarly: excessive workflow/job permissions * (some) template injections As the workflows and actions work with Zizmor's default severity/confidence, I'd advocate to use its default and not silence a lot.
Contributor
|
I'm a little confused now, we have 4 PRs modifying Zizmor: |
adutra
reviewed
Apr 17, 2026
| #min-severity: | ||
| #min-confidence: | ||
| advanced-security: ${{ github.event_name != 'pull_request' }} | ||
| annotations: ${{ github.event_name == 'pull_request' }} |
Contributor
There was a problem hiding this comment.
Strictly speaking, the "defaults" for Zizmor is to use advanced security, always. The question is how to fail a PR with advanced security on.
Member
Author
There was a problem hiding this comment.
Right. This one is mirroring what the old workflow did:
- for PRs: annotations=true + advanced-security=false
- for main/release branch CI: annotations=false + advanced-security=true
Member
Author
This is orthogonal.
This one it contrary to this PR.
This is orthogonal. |
adutra
approved these changes
Apr 17, 2026
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zizmor is a static analysis toll, which, by the nature of such tools, does not consider the context of a finding, but judges on using static patters. Users can either deal with false positives or silence a lot to a level that they don't report much by default. Hiding those can, in case of security issues, be dangerous.
'low' confidence doesn't mean that the risk does not exist nor that the issue is not exploitable.
'informational'/'low' severity issues today can become 'high' or even 'critical' ones tomorrow. Hiding those can easily give a false sense of security.
Chains of informational/low severity/confidence issues have led to exactly the recent tj-actions incident. Some of these are:
As the workflows and actions work with Zizmor's default severity/confidence, I'd advocate to use its default and not silence a lot.