fix: include user-defined attributes in PolarisPrincipal#4293
Closed
Vishwaspatel2401 wants to merge 1 commit into
Closed
fix: include user-defined attributes in PolarisPrincipal#4293Vishwaspatel2401 wants to merge 1 commit into
Vishwaspatel2401 wants to merge 1 commit into
Conversation
Fixes apache#4291: PolarisPrincipal.of(PrincipalEntity, ...) was only calling getInternalPropertiesAsMap(), silently dropping user-defined attributes set during principal creation. Now merges both maps with internal properties taking precedence on key conflicts.
Contributor
|
I believe #4292 came first and represents a reasonable try at fixing the issue, so closing this PR in favor of that one. Please feel free to re-open if this is attempting to do something extra and/or different. |
github-project-automation
Bot
moved this from PRs In Progress
to Done
in Basic Kanban Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When creating a Polaris principal with custom user-defined attributes (e.g.
region=northamerica), those attributes were silently dropped during API authentication. Only internal attributes likeclient_idwere retained.Root cause:
PolarisPrincipal.of(PrincipalEntity, ...)calledgetInternalPropertiesAsMap()exclusively, ignoring the user-defined properties stored ingetPropertiesAsMap().Fix: Merge both maps when constructing the principal, with internal properties taking precedence on key conflicts.
Fixes #4291
Checklist
CHANGELOG.md(if needed)site/content/in-dev/unreleased(if needed)