Enable Copilot for PR reviews#4452
Merged
Merged
Conversation
This change opts the Apache Polaris repository in to GitHub Copilot code review through `.asf.yaml` for initial non-draft PR reviews. The repository instructions ask Copilot to stay quiet unless the diff gives a concrete reason to suspect a missing documentation, test, or security-review update. The instructions focus on omission detection rather than certifying code correctness, test sufficiency, or documentation completeness. A CI check validates that Copilot instruction files keep path-specific frontmatter, and conservative size limits. Copilot review comments are advisory, not authoritative for merge readiness.
dimas-b
approved these changes
May 15, 2026
| copilot_code_review: | ||
| enabled: true | ||
| review_drafts: false | ||
| review_on_push: false |
Contributor
There was a problem hiding this comment.
why not review all pushes?
Member
Author
There was a problem hiding this comment.
It's a precaution - or conservative setting - to not let Copilot comment more often than necessary. We can still request another review manually for another push (like frequent rebases, non-review-worthy commit pushes).
But it's also because Copilot runs count towards actions ("minutes") usage now (or soon?), so it's not "free."
I thought, that's the better initial way. If it feels useful, we can certainly enable it later.
Contributor
There was a problem hiding this comment.
noted - makes sense - thx!
github-project-automation
Bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
github-project-automation
Bot
moved this from Ready to merge
to Done
in Basic Kanban Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change opts the Apache Polaris repository in to GitHub Copilot code review through
.asf.yamlfor initial non-draft PR reviews.The repository instructions ask Copilot to stay quiet unless the diff gives a concrete reason to suspect a missing documentation, test, or security-review update. The instructions focus on omission detection rather than certifying code correctness, test sufficiency, or documentation completeness.
A CI check validates that Copilot instruction files keep path-specific frontmatter, and conservative size limits (there's a limit on the byte-size of GH Copilot instructions).
Copilot review comments are advisory only, and not authoritative for merge readiness.