NoSQL: Use actual key serialization to split NoSQL index stripes#4567
Draft
snazy wants to merge 2 commits into
Draft
NoSQL: Use actual key serialization to split NoSQL index stripes#4567snazy wants to merge 2 commits into
snazy wants to merge 2 commits into
Conversation
Replace the old count-oriented stripe split behavior with a target-size driven path at the UpdatableIndexImpl level. That keeps oversized stripes from dragging too much neighboring data along when we have to rewrite them, and it gives us better control over large entry distributions.
Base stripe splitting on the actual serialized key shape, including prefix compression, instead of a loose full-key estimate. The estimate was safe but too pessimistic and could over-split perfectly reasonable stripes. Reuse the real serialization walk so the split logic and persisted bytes stay aligned.
snazy
force-pushed
the
nosql-index-stripe-sizing
branch
from
3cc7380 to
11b0cfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base stripe splitting on the actual serialized key shape, including prefix compression, instead of a loose full-key estimate.
The estimate was safe but too pessimistic and could over-split perfectly reasonable stripes.
Reuse the real serialization walk so the split logic and persisted bytes stay aligned.
Depends on and follow-up of #4566