Fix source distribution LICENSE and NOTICE #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbonofre
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
snazy,
takidau and
vvcephei
as code owners
snazy
reviewed
Jan 15, 2025
jbonofre
force-pushed
the
LICENSE_FIX
branch
2 times, most recently
from
fc7f290 to
dc86e5f
Compare
Member
Author
|
@rdblue do you mind to take a look on this PR if it's OK for you ? Thanks |
Member
Author
|
NB: I will adapt this for the |
rdblue
reviewed
Jan 16, 2025
rdblue
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Why would this be part of the version? This cannot be accurate because this class doesn't know what was bundled or how dependencies were pulled in.
Member
Author
There was a problem hiding this comment.
Fair question, but my change here is just to remove LICENSE-BINARY-DIST. Your question/point can be cast on the PR when we will renable it (I don't have the history about version content here 😄 ).
snazy
approved these changes
Jan 20, 2025
jbonofre
added a commit
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following 0.9.0-incubating rc2 vote, this PR:
LICENSEandNOTICEfor the source distributionLICENSE-BINARY-DISTfrom the source distribution to avoid confusion (with binary distributions)