Add specialized polaris-quarkus build-plugin
#787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a `polaris-quarkus` build-plugin based on `polaris-server`. It has the specialties for Quarkus based projects, like the implicit `intTest` suite. This has the nice side effect of not having an unused `intTest` test suite in every project, and removes a bunch of `if`s.
snazy
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
takidau and
vvcephei
as code owners
dimas-b
reviewed
Jan 15, 2025
| targets.all { | ||
| if (testTask.name != "test") { | ||
| testTask.configure { | ||
| // For Quarkus... |
Contributor
There was a problem hiding this comment.
nit: "Quarkus" is already implied by the plugin name.
| alias(libs.plugins.quarkus) | ||
| alias(libs.plugins.jandex) | ||
| id("polaris-server") | ||
| id("polaris-quarkus") |
Contributor
There was a problem hiding this comment.
Does "service" stuff have to depend on Quarkus?
Member
Author
There was a problem hiding this comment.
It has the quarkus plugin, that's why
Contributor
There was a problem hiding this comment.
hmm... I need to read up on that code 😅
dimas-b
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
polaris-quarkusbuild-plugin based onpolaris-server. It has the specialties for Quarkus based projects, like the implicitintTestsuite.This has the nice side effect of not having an unused
intTesttest suite in every project, and removes a bunch ofifs.