Move default Quarkus config to a separate module. #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
dennishuo,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
snazy
reviewed
Jan 17, 2025
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
Overall LGTM.
But this new module needs a "dummy" package-info.java and tasks.withType<Javadoc> { isFailOnError = false } in the build script - otherwise publications to Maven Central may break.
Add `quarkus/defaults` to contain just the default `application.properties` (for now). This allows reusing `quarkus/service` with a different set of quarkus properties.
dimas-b
force-pushed
the
quarkus-properties
branch
from
321f17c to
58d0fbf
Compare
collado-mike
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
quarkus/defaultsto contain just the defaultapplication.properties(for now).This allows reusing
quarkus/servicewith a different set of quarkus properties.