Add docs for telemetry (metrics, traces and logging) #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
requested review from
RussellSpitzer,
ashvina,
collado-mike,
dennishuo,
dimas-b,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
adutra
added
the
documentation
dimas-b
approved these changes
Jan 22, 2025
Contributor
dimas-b
left a comment
dimas-b
left a comment
There was a problem hiding this comment.
It's great to have these capabilities in Poalris :)
flyrain
approved these changes
Jan 23, 2025
Contributor
flyrain
left a comment
flyrain
left a comment
There was a problem hiding this comment.
LGTM overall with minor suggestions. Feel free to merge it once they are resolved.
Comment on lines
57
to
59
| In order for the server to enable OpenTelemetry and publish its traces, the | ||
| `quarkus.otel.exporter.otlp.traces.endpoint` property _must_ be defined. Its value must be a valid | ||
| collector endpoint URL, with either `http://` or `https://` scheme. The collector must talk the |
Contributor
There was a problem hiding this comment.
Suggested change
| In order for the server to enable OpenTelemetry and publish its traces, the | |
| `quarkus.otel.exporter.otlp.traces.endpoint` property _must_ be defined. Its value must be a valid | |
| collector endpoint URL, with either `http://` or `https://` scheme. The collector must talk the | |
| To enable OpenTelemetry and publish traces for Polaris, set a valid collector endpoint URL with `http://` or `https://` as the server property `quarkus.otel.exporter.otlp.traces.endpoint`. The collector must talk the |
Comment on lines
63
to
64
| Alternatively, it's possible to forcibly disable OpenTelemetry at runtime by setting the following | ||
| property: `quarkus.otel.sdk.disabled=true`. |
Contributor
There was a problem hiding this comment.
Suggested change
| Alternatively, it's possible to forcibly disable OpenTelemetry at runtime by setting the following | |
| property: `quarkus.otel.sdk.disabled=true`. | |
| You can disable OpenTelemetry at runtime by setting `quarkus.otel.sdk.disabled=true`. |
flyrain
approved these changes
Jan 23, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.