Skip to content

Handle non-buffer binary data in node#8198

Closed
cortopy wants to merge 1 commit intoapache:masterfrom
cortopy:binary-non-buffer-in-node
Closed

Handle non-buffer binary data in node#8198
cortopy wants to merge 1 commit intoapache:masterfrom
cortopy:binary-non-buffer-in-node

Conversation

@cortopy
Copy link
Copy Markdown

@cortopy cortopy commented Sep 30, 2020

The difference between browser and node generally works well. However, there are some instances in which the boundaries are not that clear. For example:

  • Jest runtime that loads jsdom in the background
  • Server side rendering of single-page applications (that may also rely on some kind of DOM implementation in node to simulate a browser-like environment)

I bumped into this issue when testing attachments in my application. I believe these changes fix the issue.

Apologies for not adding any tests. This is my first contribution and for what I can see, node tests are run with mocha and browser tests with a headless browser.

If tests are required, I can add them but I'd need to know which would be the best way of replicating those two use cases above in current tests setup. Any help in this regards would be much appreciated

@janl
Copy link
Copy Markdown
Member

janl commented Feb 12, 2021

we’d need tests, and no CI build failures :)

@dheimoz
Copy link
Copy Markdown

dheimoz commented Oct 19, 2021

hello @cortopy would you like to have your contribution reviewed? Tests have been migrated to Github Actions.

@AlbaHerrerias
Copy link
Copy Markdown
Contributor

Hey @cortopy, could you rebase from master? It will allow me to trigger Github actions. Thanks!

@alxndrsn
Copy link
Copy Markdown
Contributor

No action for 5 years.

@alxndrsn alxndrsn closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants