Draft
Conversation
jcoglan
force-pushed
the
multitab-tests
branch
5 times, most recently
from
6c9a6e6 to
b85a439
Compare
jcoglan
force-pushed
the
multitab-tests
branch
4 times, most recently
from
e6d05b1 to
50a59f6
Compare
janl
approved these changes
Mar 27, 2026
alxndrsn
requested changes
Mar 28, 2026
Contributor
alxndrsn
left a comment
alxndrsn
left a comment
There was a problem hiding this comment.
This looks great! 👍
Not sure that the changes to README.md are relevant.
| "emit": "readonly", | ||
| "PouchDB": "readonly" | ||
| "PouchDB": "readonly", | ||
| "__pouch__": "readonly" |
Contributor
There was a problem hiding this comment.
Could window.__pouch__ could be used instead of adding an extra constant here?
| > **Always set the `COUCH_HOST` env var to a proper CouchDB for the integration tests!** | ||
| > [!WARNING] | ||
| > VERY IMPORTANT **Always set the `COUCH_HOST` env var to a proper CouchDB for | ||
| > the integration tests!** |
Contributor
There was a problem hiding this comment.
Are these changes related to the new tests?
| return page.evaluate(fn); | ||
| } | ||
|
|
||
| _getPage(id) { |
Contributor
There was a problem hiding this comment.
"page" means "tab"? Maybe helpful to use consistent language?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Testing recommendations
Related Issues or Pull Requests
Checklist
docsfolder