Add Storm adapter back after removing from Apache Storm repo#55
Merged
rdhabalia merged 1 commit intoapache:masterfrom Nov 1, 2023
Merged
Add Storm adapter back after removing from Apache Storm repo#55rdhabalia merged 1 commit intoapache:masterfrom
rdhabalia merged 1 commit intoapache:masterfrom
Conversation
This reverts commit ab537c1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes #54
Motivation
Storm community has decided to remove Pulsar and other modules from the storm repo JIRA and PR is also merged now. Pulsar-storm is widely used adapter library and we have to add it back to Pulsar-Adapter repo to maintain and support bug fixes and new pulsar features.
Modifications
Adding Pulsar-Storm module back to Pulsar-adapter repo.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation