Skip to content

Add Storm adapter back after removing from Apache Storm repo#55

Merged
rdhabalia merged 1 commit intoapache:masterfrom
rdhabalia:storm
Nov 1, 2023
Merged

Add Storm adapter back after removing from Apache Storm repo#55
rdhabalia merged 1 commit intoapache:masterfrom
rdhabalia:storm

Conversation

@rdhabalia
Copy link
Contributor

It fixes #54

Motivation

Storm community has decided to remove Pulsar and other modules from the storm repo JIRA and PR is also merged now. Pulsar-storm is widely used adapter library and we have to add it back to Pulsar-Adapter repo to maintain and support bug fixes and new pulsar features.

Modifications

Adding Pulsar-Storm module back to Pulsar-adapter repo.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@eolivelli eolivelli changed the title Add Strom adapter back after removing from Apache Storm repo Add Storm adapter back after removing from Apache Storm repo Nov 1, 2023
@rdhabalia rdhabalia merged commit 5aeddbb into apache:master Nov 1, 2023
@rdhabalia rdhabalia deleted the storm branch November 1, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Pulsar-Storm adapter into repo

2 participants