[fix][client-cpp] Restore pulsar/Version.h for the dev package#572
Open
dwarburt wants to merge 1 commit intoapache:mainfrom
Open
[fix][client-cpp] Restore pulsar/Version.h for the dev package#572dwarburt wants to merge 1 commit intoapache:mainfrom
dwarburt wants to merge 1 commit intoapache:mainfrom
Conversation
BewareMyPower
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #570
Motivation
My application using pulsar-client-cpp reads the version number to generate some diagnostic logs. This worked fine when I was building pulsar-client-cpp from source, but I've switched to building against the debian packages and the build failed when pulsar/Version.h was missing.
Modifications
The debian packaging scripts grab the headers from the source archive but the Version.h is generated from a template (Version.h.in) and so it is not present in the source archive. I've added a couple of file copy commands to make sure the file makes it into the final package.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-requireddoc-not-neededThe documentation already states this header will be present
docdoc-complete