Skip to content

chore: remove unnecessary WARN logs for send or receive timeouts #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BewareMyPower merged 1 commit into from
Jun 1, 2026
+3 −16
Merged

chore: remove unnecessary WARN logs for send or receive timeouts #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions lib/ConsumerImpl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1117,14 +1117,6 @@ Result ConsumerImpl::receiveHelper(Message& msg, int timeout) {
if (state_ != Ready) {
return ResultAlreadyClosed;
}
auto cnx = getCnx().lock();
if (cnx) {
LOG_WARN(getName() << " Receive timeout after " << timeout << " ms, connection: "
<< cnx->cnxString() << ", queue size: " << incomingMessages_.size());
} else {
LOG_WARN(getName() << " Receive timeout after " << timeout
<< " ms, no connection, queue size: " << incomingMessages_.size());
}
return ResultTimeout;
}
}
Expand Down
8 changes: 0 additions & 8 deletions lib/MultiTopicsConsumerImpl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,14 +603,6 @@ Result MultiTopicsConsumerImpl::receive(Message& msg, int timeout) {
if (state_ != Ready) {
return ResultAlreadyClosed;
}
auto cnx = getCnx().lock();
if (cnx) {
LOG_WARN(getName() << " Receive timeout after " << timeout << " ms, connection: "
<< cnx->cnxString() << ", queue size: " << incomingMessages_.size());
} else {
LOG_WARN(getName() << " Receive timeout after " << timeout
<< " ms, no connection, queue size: " << incomingMessages_.size());
}
return ResultTimeout;
}
}
Expand Down
3 changes: 3 additions & 0 deletions lib/ProducerImpl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,6 +873,9 @@ void ProducerImpl::handleSendTimeout(const ASIO_ERROR& err) {
}

lock.unlock();
if (pendingMessages.empty()) {
return;
}
auto cnx = getCnx().lock();
if (cnx) {
LOG_WARN(getName() << "Send timeout due to queueing delay, connection: " << cnx->cnxString()
Expand Down
Loading