Fix partition key not set in batch builder#175
Merged
merlimat merged 1 commit intoapache:masterfrom Jan 16, 2020
Merged
Conversation
Signed-off-by: xiaolong.ran <rxl@apache.org>
Member
Author
cckellogg
reviewed
Jan 16, 2020
|
|
||
| ctx := context.Background() | ||
| for i := 0; i < 10; i++ { | ||
| for i := 0; i < 100; i++ { |
Contributor
There was a problem hiding this comment.
What's the purpose of changing this from 10 -> 100?
Member
Author
There was a problem hiding this comment.
Just to ensure that every consumer receives a message
merlimat
approved these changes
Jan 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolong.ran rxl@apache.org
Motivation
Currently, when we specify the
Keyfor the message, the broker can not receive the partition key.Modifications