Add VPC（Virtual Private Cloud）support for go sdk#402
Closed
xixiss wants to merge 9 commits intoapache:masterfrom
Closed
Add VPC（Virtual Private Cloud）support for go sdk#402xixiss wants to merge 9 commits intoapache:masterfrom
xixiss wants to merge 9 commits intoapache:masterfrom
Conversation
wolfstudy
requested review from
merlimat and
wolfstudy
and removed request for
merlimat
Member
|
@xixiss Move this change to 0.5.0 |
wolfstudy
reviewed
Feb 9, 2021
| RequestId: proto.Uint64(1), | ||
| Topic: proto.String("my-topic"), | ||
| Authoritative: proto.Bool(false), | ||
| AdvertisedListenerName: proto.String(""), |
Member
There was a problem hiding this comment.
@xixiss Can you add new test case for this change? This test case is used to cover other scenarios, please do not verify our own logic in this test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add listenerName field in ClientOptions to support VPC（Virtual Private Cloud）net mode in cloud environment when create client.Then sdk can use vpc mode when lookup for topics.
Modifications