Skip to content

Conversation

@BewareMyPower
Copy link
Contributor

Motivation

There is no workflow to verify the fastavro dependency works well for all supported Python versions, so the [avro] component was broken and not found before. See #67

Modifications

  • In all workflows, install the wheel with the [avro] component and verify pulsar.schema can be imported successfully.
  • Add workflows for the lowest Python version (3.7) we supported.

### Motivation

There is no workflow to verify the fastavro dependency works well for
all supported Python versions, so the `[avro]` component was broken and
not found before. See apache#67

### Modifications

- In all workflows, install the wheel with the `[avro]` component and
  verify `pulsar.schema` can be imported successfully.
- Add workflows for the lowest Python version (3.7) we supported.
@BewareMyPower BewareMyPower added this to the 3.2.0 milestone Apr 20, 2023
@BewareMyPower BewareMyPower self-assigned this Apr 20, 2023
@BewareMyPower
Copy link
Contributor Author

It seems that there is something wrong with the Python 3.7 build on macOS

WARNING: pip is configured with locations that require TLS/SSL, however the ssl module in Python is not available.
Could not fetch URL https://pypi.org/simple/pip/: There was a problem confirming the ssl certificate: HTTPSConnectionPool(host='pypi.org', port=443): Max retries exceeded with url: /simple/pip/ (Caused by SSLError("Can't connect to HTTPS URL because the SSL module is not available.")) - skipping
+ /Users/runner/work/pulsar-client-python/pulsar-client-python/.pulsar-mac-build/deps/install/bin/python3 -c 'import pulsar; c = pulsar.Client("pulsar://localhost:6650"); c.close()'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/runner/work/pulsar-client-python/pulsar-client-python/.pulsar-mac-build/deps/install/lib/python3.7/site-packages/pulsar/__init__.py", line 459, in __init__
    import certifi
ModuleNotFoundError: No module named 'certifi'

@BewareMyPower
Copy link
Contributor Author

I think we need to build Python with the SSL support for macOS build. I will fix it soon.

@BewareMyPower BewareMyPower marked this pull request as draft April 20, 2023 10:36
@BewareMyPower BewareMyPower modified the milestones: 3.2.0, 3.3.0 May 29, 2023
@tisonkun tisonkun removed their request for review May 31, 2023 14:30
@tisonkun
Copy link
Member

It seems the error remains after the last patch.

@BewareMyPower
Copy link
Contributor Author

It seems the error remains after the last patch.

Yes. I need to verify it in my local env first. Recently I don't have much time for this issue.

@shibd shibd modified the milestones: 3.3.0, 3.4.0 Aug 15, 2023
@BewareMyPower BewareMyPower deleted the bewaremypower/ci-py-3.7 branch December 25, 2023 11:53
@BewareMyPower BewareMyPower removed this from the 3.4.0 milestone Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants