Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pulsar/asyncio.py
Original file line number Diff line number Diff line change
Expand Up @@ -828,6 +828,8 @@ async def close(self) -> None:

def _set_future(future: asyncio.Future, result: _pulsar.Result, value: Any):
def complete():
if future.done():
return
if result == _pulsar.Result.Ok:
future.set_result(value)
else:
Expand Down
21 changes: 21 additions & 0 deletions tests/asyncio_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
Consumer,
Producer,
PulsarException,
_set_future,
)
from pulsar.schema import ( # pylint: disable=import-error
AvroSchema,
Expand Down Expand Up @@ -484,5 +485,25 @@ class ExampleRecord(Record): # pylint: disable=too-few-public-methods
self.assertEqual(msg.value().int_field, 42)


class AsyncioSetFutureTest(IsolatedAsyncioTestCase):
"""Tests for asyncio bridge helpers (no live Pulsar broker)."""

async def test_set_future_noop_when_future_cancelled(self):
loop = asyncio.get_running_loop()
fut = loop.create_future()
fut.cancel()
_set_future(fut, _pulsar.Result.Ok, None)
await asyncio.sleep(0)
self.assertTrue(fut.cancelled())

async def test_set_future_noop_when_future_already_resolved(self):
loop = asyncio.get_running_loop()
fut = loop.create_future()
fut.set_result("first")
_set_future(fut, _pulsar.Result.Ok, "late")
await asyncio.sleep(0)
self.assertEqual(fut.result(), "first")


if __name__ == '__main__':
main()