Conversation
Fixed the case when no ZK annotations are set and `zookeeper.restartPodsOnConfigMapChange: true` helm can not render template
Contributor
Author
|
ping - any feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the case when no ZK annotations are set and
zookeeper.restartPodsOnConfigMapChange: truehelm can not render templateMotivation
When you don't set any annotations to Zookeeper (they are empty by default) AND if you set
in your values.yaml file, the manifest can not be rendered. This commit fixes this condition and also unifies the
the way how the custom annotations are added, with bookkeeper statefulset template.
Modifications
wrapping
toYamlfilter (that can return empty object{}) intowithcontext.Verifying this change