Add CI step to validate helm template renders with all features enabled#684
Merged
lhotari merged 1 commit intoapache:masterfrom May 4, 2026
Merged
Add CI step to validate helm template renders with all features enabled#684lhotari merged 1 commit intoapache:masterfrom
lhotari merged 1 commit intoapache:masterfrom
Conversation
Adds .ci/templates-all-values.yaml (every optional feature on, with multi-element lists and maps for every list/map-shaped value) and .ci/templates-all-values-patch1.yaml (overlay that flips mutually-exclusive choices: zookeeper -> oxia, JWT symmetric -> OpenID, selfsigning -> ca issuer, multiVolumes -> single common bookkeeper volume, hard -> soft anti-affinity, etc.). A new step in the ct-lint job renders both combinations with `helm template` and validates them with `kubeconform -strict` against k8s 1.34.0. This catches indent / `range` / `toYaml | nindent` bugs that no individual scenario in .ci/clusters/ can surface on its own, since each existing scenario only enables one or two features at a time. Also fixes two real bugs uncovered by writing the test: oxia-coordinator-serviceaccount.yaml and oxia-server-serviceaccount.yaml treated `images.imagePullSecrets` as an object with `.secretName`, but per the schema in values.yaml and the `pulsar.imagePullSecrets` helper, it is a list of secret-name strings. Both files now use the shared helper and template-error no longer when the field is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds .ci/templates-all-values.yaml (every optional feature on, with multi-element lists and maps for every list/map-shaped value) and .ci/templates-all-values-patch1.yaml (overlay that flips mutually-exclusive choices: zookeeper -> oxia, JWT symmetric -> OpenID, selfsigning -> ca issuer, multiVolumes -> single common bookkeeper volume, hard -> soft anti-affinity, etc.). A new step in the ct-lint job renders both combinations with
helm templateand validates them withkubeconform -strictagainst k8s 1.34.0.This catches indent /
range/toYaml | nindentbugs that no individual scenario in .ci/clusters/ can surface on its own, since each existing scenario only enables one or two features at a time.Also fixes two real bugs uncovered by writing the test: oxia-coordinator-serviceaccount.yaml and oxia-server-serviceaccount.yaml treated
images.imagePullSecretsas an object with.secretName, but per the schema in values.yaml and thepulsar.imagePullSecretshelper, it is a list of secret-name strings. Both files now use the shared helper and template-error no longer when the field is set.