Skip to content

Update README.md regarding issues/283#314

Merged
sijie merged 2 commits into
apache:masterfrom
josuemotte:patch-1
Jul 2, 2020
Merged

Update README.md regarding issues/283#314
sijie merged 2 commits into
apache:masterfrom
josuemotte:patch-1

Conversation

@josuemotte
Copy link
Copy Markdown
Contributor

  • added an example line in case using the standalone version.
  • added the name of the file in case using pulsar-manager binary/source.

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the ./gradlew build checks.

- added an example line in case using the standalone version.
- added the name of the file in case using pulsar-manager binary/source.
Copy link
Copy Markdown

@Huanli-Meng Huanli-Meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor comment, PTAL

Comment thread README.md Outdated
Co-authored-by: HuanliMeng <48120384+Huanli-Meng@users.noreply.github.com>
@sijie sijie added this to the 0.2.0 milestone Jul 2, 2020
@sijie sijie merged commit 42025e0 into apache:master Jul 2, 2020
@josuemotte josuemotte deleted the patch-1 branch July 2, 2020 08:26
sde-melo pushed a commit to Singlespot/pulsar-manager that referenced this pull request Jan 15, 2021
* Update README.md regarding issues/283

- added an example line in case using the standalone version.
- added the name of the file in case using pulsar-manager binary/source.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants