Merged
Conversation
4 tasks
tisonkun
requested changes
Nov 18, 2022
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Good change. Comment inline.
Comment on lines
7
to
15
| - [BookKeeper](/next/config/reference-configuration-bookkeeper/) | ||
| - [Broker](/next/config/reference-configuration-broker/) | ||
| - [Client](/next/config/reference-configuration-client/) | ||
| - [Log4j](/next/config/reference-configuration-log4j/) | ||
| - [Log4j shell](/next/config/reference-configuration-log4j-shell/) | ||
| - [Standalone](/next/config/reference-configuration-standalone/) | ||
| - [WebSocket](/next/config/reference-configuration-websocket/) | ||
| - [Pulsar proxy](/next/config/reference-configuration-pulsar-proxy/) | ||
| - [ZooKeeper](/next/config/reference-configuration-zookeeper/) |
Member
There was a problem hiding this comment.
Suggested change
| - [BookKeeper](/next/config/reference-configuration-bookkeeper/) | |
| - [Broker](/next/config/reference-configuration-broker/) | |
| - [Client](/next/config/reference-configuration-client/) | |
| - [Log4j](/next/config/reference-configuration-log4j/) | |
| - [Log4j shell](/next/config/reference-configuration-log4j-shell/) | |
| - [Standalone](/next/config/reference-configuration-standalone/) | |
| - [WebSocket](/next/config/reference-configuration-websocket/) | |
| - [Pulsar proxy](/next/config/reference-configuration-pulsar-proxy/) | |
| - [ZooKeeper](/next/config/reference-configuration-zookeeper/) | |
| - [BookKeeper](/next/config/reference-configuration-bookkeeper) | |
| - [Broker](/next/config/reference-configuration-broker) | |
| - [Client](/next/config/reference-configuration-client) | |
| - [Log4j](/next/config/reference-configuration-log4j) | |
| - [Log4j shell](/next/config/reference-configuration-log4j-shell) | |
| - [Standalone](/next/config/reference-configuration-standalone) | |
| - [WebSocket](/next/config/reference-configuration-websocket) | |
| - [Pulsar proxy](/next/config/reference-configuration-pulsar-proxy) | |
| - [ZooKeeper](/next/config/reference-configuration-zookeeper) |
With a trailing slash, the preview failed.
Also, I'm trying to avoid /next/config prefix.
Comment on lines
21
to
24
| |Prefix|Description| | ||
| |---|---| | ||
| |brokerClient_| Configure **all** the Pulsar Clients and Pulsar Admin Clients of brokers, websockets, and proxies. These configurations are applied after hard-coded configurations and before the client configurations named in this site.| | ||
| |bookkeeper_| Configure the broker's BookKeeper clients used by managed ledgers and the BookkeeperPackagesStorage bookkeeper client. Takes precedence over most other configuration values.| |
Member
There was a problem hiding this comment.
Suggested change
| |Prefix|Description| | |
| |---|---| | |
| |brokerClient_| Configure **all** the Pulsar Clients and Pulsar Admin Clients of brokers, websockets, and proxies. These configurations are applied after hard-coded configurations and before the client configurations named in this site.| | |
| |bookkeeper_| Configure the broker's BookKeeper clients used by managed ledgers and the BookkeeperPackagesStorage bookkeeper client. Takes precedence over most other configuration values.| | |
| | Prefix | Description | | |
| |---------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | |
| | brokerClient_ | Configure **all** the Pulsar Clients and Pulsar Admin Clients of brokers, websockets, and proxies. These configurations are applied after hard-coded configurations and before the client configurations named in this site. | | |
| | bookkeeper_ | Configure the broker's BookKeeper clients used by managed ledgers and the BookkeeperPackagesStorage bookkeeper client. Takes precedence over most other configuration values. |
Reformat. This is not required.
Contributor
Author
|
Thanks, @tisonkun. Comments have been addressed. |
Anonymitaet
approved these changes
Nov 18, 2022
tisonkun
approved these changes
Nov 18, 2022
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Merging...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes apache/pulsar#18490
The preview looks good: