Skip to content

[improve][develop-plugin] Add section for AdditionalServlet plugins#361

Merged
momo-jun merged 1 commit intoapache:mainfrom
alpreu:patch-1
Jan 12, 2023
Merged

[improve][develop-plugin] Add section for AdditionalServlet plugins#361
momo-jun merged 1 commit intoapache:mainfrom
alpreu:patch-1

Conversation

@alpreu
Copy link
Contributor

@alpreu alpreu commented Jan 5, 2023

Motivation

There is currently no description of adding custom servlets using Pulsar's plugin architecture

Screenshots

1

2

3

4

@tisonkun
Copy link
Member

tisonkun commented Jan 5, 2023

I'm not sure who is familiar with plugins, so cc @codelipenghui @merlimat. It's encouraged to delegate to domain experts and we know who is suitable as a reviewer then.

@alpreu
Copy link
Contributor Author

alpreu commented Jan 5, 2023

I'm not sure who is familiar with plugins, so cc @codelipenghui @merlimat. It's encouraged to delegate to domain experts and we know who is suitable as a reviewer then.

I know @andrasbeni wrote an integration test, maybe he can help out with reviewing

@andrasbeni
Copy link

The content looks good from an engineering point of view.
I'd love to see a few words about how AdditionalServletWithPulsarService can be used instead of AdditionalServlet when the developer wants the servlet to have access to Pulsar internals (for e.g., producing messages or performing administrative tasks). But I don't insist.

Copy link
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Overall LGTM. I left a minor suggestion.

@alpreu
Copy link
Contributor Author

alpreu commented Jan 9, 2023

Thanks for the review everyone! I applied your suggestions and added a small note for when to use AdditionalServletWithPulsarService

@alpreu alpreu requested review from momo-jun and removed request for codelipenghui and merlimat January 12, 2023 11:27
Copy link
Contributor

@momo-jun momo-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alpreu Thanks for adding the docs!
By the way, 2.11.0 was released during the review window. Is it possible that you can also sync the contributions to pulsar-site/versioned_docs/version-2.11.x? Thank you.

@alpreu
Copy link
Contributor Author

alpreu commented Jan 12, 2023

@momo-jun I rebased now and added the 2.11 version as well, should be good to go now :)

@momo-jun momo-jun merged commit 99da69c into apache:main Jan 12, 2023
@Anonymitaet Anonymitaet added this to the 3.0.0 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments