Skip to content

Don't require webServicePort to allow for TLS only listeners #10124

@addisonj

Description

@addisonj

Describe the bug
In the code, webServicePort is marked as optional and in many places in the code, we properly check if it is present before starting a non TLS listener.

However, other paths in code are not properly checking this. For example:

if (LOG.isDebugEnabled()) {
LOG.debug("Broker not found for SLA Monitoring Namespace {}",
candidateBroker + ":" + config.getWebServicePort().get());
}

This not the only instance, there are a number of other places, such as when functions is enabled.

To Reproduce
Steps to reproduce the behavior:

  1. Run a broker with only TLS (set webServicePort= to empty)

Perform some actions and potentially get a crash

Expected behavior
We should not required webServicePort to be required and we should be properly checking everything for the optional usage.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions