-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Closed
Labels
good first issueGood for newcomersGood for newcomershelp wantedtype/bugThe PR fixed a bug or issue reported a bugThe PR fixed a bug or issue reported a bug
Description
Describe the bug
In the code, webServicePort is marked as optional and in many places in the code, we properly check if it is present before starting a non TLS listener.
However, other paths in code are not properly checking this. For example:
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
Lines 615 to 618 in bf00673
| if (LOG.isDebugEnabled()) { | |
| LOG.debug("Broker not found for SLA Monitoring Namespace {}", | |
| candidateBroker + ":" + config.getWebServicePort().get()); | |
| } |
This not the only instance, there are a number of other places, such as when functions is enabled.
To Reproduce
Steps to reproduce the behavior:
- Run a broker with only TLS (set
webServicePort=to empty)
Perform some actions and potentially get a crash
Expected behavior
We should not required webServicePort to be required and we should be properly checking everything for the optional usage.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedtype/bugThe PR fixed a bug or issue reported a bugThe PR fixed a bug or issue reported a bug