licence check has issues

[jiazhai]

after mvn install -DskipTests, run command src/check-binary-license will return errors:

$ src/check-binary-license distribution/server/target/apache-pulsar-2.6.0-SNAPSHOT-bin.tar.gz
aopalliance-repackaged-2.5.0-b42.jar unaccounted for in lib/presto/LICENSE
httpclient-4.5.5.jar unaccounted for in lib/presto/LICENSE
httpcore-4.4.9.jar unaccounted for in lib/presto/LICENSE
javassist-3.22.0-CR2.jar unaccounted for in lib/presto/LICENSE
javax.inject-2.5.0-b42.jar unaccounted for in lib/presto/LICENSE
jersey-client-2.27.jar unaccounted for in lib/presto/LICENSE
jersey-common-2.27.jar unaccounted for in lib/presto/LICENSE
jersey-entity-filtering-2.27.jar unaccounted for in lib/presto/LICENSE
jersey-hk2-2.27.jar unaccounted for in lib/presto/LICENSE
jersey-media-json-jackson-2.27.jar unaccounted for in lib/presto/LICENSE
jersey-media-multipart-2.27.jar unaccounted for in lib/presto/LICENSE
pulsar-client-original-2.6.0-SNAPSHOT.jar unaccounted for in lib/presto/LICENSE
pulsar-metadata-2.6.0-SNAPSHOT.jar unaccounted for in lib/presto/LICENSE
netty-codec-socks-4.1.48.Final.jar mentioned in lib/presto/LICENSE, but not bundled
netty-handler-proxy-4.1.48.Final.jar mentioned in lib/presto/LICENSE, but not bundled
It looks like there are issues with the LICENSE/NOTICE.

[jiazhai]

looks like these jars are counted twice,
e.g. aopalliance-repackaged-2.5.0-b42.jar
first counted as:
org.glassfish.hk2.external-aopalliance-repackaged-2.5.0-b42.jar
then the prefix was removed and counted as :
aopalliance-repackaged-2.5.0-b42.jar
again.

The second round check is for pulsar-sql, the prefix was dropped, and reported as unaccounted.

[jiazhai]

this is the same issue as #6501, which was caused by mvn-3.6.3.

[tisonkun]

Closed as stale. Feel free to open a new issue if it's still relevant for maintained versions.

IIRC we made several improvements to this script later.