Upgrade k8s java-client to fix dependency resolution#10260
Merged
sijie merged 1 commit intoapache:masterfrom Apr 20, 2021
Merged
Upgrade k8s java-client to fix dependency resolution#10260sijie merged 1 commit intoapache:masterfrom
sijie merged 1 commit intoapache:masterfrom
Conversation
- sundr library has been upgraded to 0.22.1 version which contains a fix to an issue which causes issues with dependency resolution, sundrio/sundrio#168 - various workarounds for sundr library dependency issues can be removed - newer version of k8s java-client has less dependencies which addresses some other dependency issues
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
@jerrypeng @david-streamlio Please review this change. |
eolivelli
approved these changes
Apr 19, 2021
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
LGTM
we are updating the Kubernetes Java Client, this may affect Pulsar functions behaviour on k8s.
can you please test that they still work ?
Member
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Apr 19, 2021
Member
Author
|
@jerrypeng What would be the best way to verify this PR? |
sijie
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
sundr library has been upgraded to 0.22.1 version which contains a fix a dependency resolution issue, sundr-codegen: Absolute path in published POM sundrio/sundrio#168
newer version of k8s java-client has fewer dependencies
Modifications
coreClient.listNamespacedPodsince the api has changed (1 new parameter, passes as null)pulsar-sql/presto-distribution/pom.xml