[Tests] Fix AvroSchemaTest on JDK11#10342
Merged
merlimat merged 2 commits intoapache:masterfrom Apr 23, 2021
Merged
Conversation
315157973
approved these changes
Apr 23, 2021
merlimat
approved these changes
Apr 23, 2021
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 18, 2021
* [Tests] Fix AvroSchemaTest on JDK11 * Fix 2 other similar tests (cherry picked from commit ff180fc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10122
Motivation
Modifications
When testing time fields at millisecond precision, use
LocalTime.now().truncatedTo(ChronoUnit.MILLIS)instead ofLocalTime.now().On Java 8,
LocalTime.now()has millisecond precision, but on Java 11, there is microsecond precision by default. The change in JDK is https://bugs.openjdk.java.net/browse/JDK-8068730 .