Skip to content

Comments

[Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar#10670

Closed
Jason918 wants to merge 1 commit intoapache:masterfrom
Jason918:jht_dev_2
Closed

[Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar#10670
Jason918 wants to merge 1 commit intoapache:masterfrom
Jason918:jht_dev_2

Conversation

@Jason918
Copy link
Contributor

Fixes #10669

Motivation

GC log is useful for production environment, I think it should take affect by default.

@jiazhai
Copy link
Member

jiazhai commented May 24, 2021

/pulsarbot run-failure-checks

@jiazhai
Copy link
Member

jiazhai commented May 24, 2021

@merlimat @codelipenghui What do you think of this change?

@hangc0276
Copy link
Contributor

/pulsarbot run-failure-checks

@hangc0276
Copy link
Contributor

@Jason918 For bookie startup, it will be better to add gc log too. In my production env, i have add the gc log for broker, zookeeper and bookie.

@jiazhai
Copy link
Member

jiazhai commented May 26, 2021

/pulsarbot run-failure-checks

@jiazhai
Copy link
Member

jiazhai commented May 26, 2021

@Jason918 Would you please help update your branch with the latest master? seems the always CI get failed.

@Jason918
Copy link
Contributor Author

@Jason918 For bookie startup, it will be better to add gc log too. In my production env, i have add the gc log for broker, zookeeper and bookie.

OK, Added gc log for bookie in the updates.

@Jason918
Copy link
Contributor Author

Jason918 commented May 27, 2021

@Jason918 Would you please help update your branch with the latest master? seems the always CI get failed.

OK, merged with master.
BTW, Is it my commits causing the CI failed? These updates seem trivial.

@codelipenghui codelipenghui added this to the 2.9.0 milestone Jun 7, 2021
@codelipenghui
Copy link
Contributor

I agree with the motivation of the PR, it's useful for the production environment. Since we are trying to change the default value, it will make difference in the new Pulsar release, I think it's better to discuss this at the dev email thread first.

@eolivelli eolivelli modified the milestones: 2.9.0, 2.10.0 Oct 6, 2021
@codelipenghui codelipenghui modified the milestones: 2.10.0, 2.11.0 Jan 18, 2022
@Jason918 Jason918 closed this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$PULSAR_GC_LOG not working when start broker with bin/pulsar

5 participants