Skip to content

Conversation

@codelipenghui
Copy link
Contributor

Fixes #10834

Motivation

Since the #10728
make the pulsar sql module to be a child of Pulsar main project
we don't need to run the specific set-version for the presto-distribution

Since the apache#10728
make the pulsar sql module to be a child of Pulsar main project
we don't need to run the specific set-version for the presto-distribution
@codelipenghui
Copy link
Contributor Author

Thanks for the quick review @lhotari

@codelipenghui codelipenghui self-assigned this Jun 6, 2021
@codelipenghui codelipenghui added this to the 2.8.0 milestone Jun 6, 2021
@codelipenghui codelipenghui added the release/blocker Indicate the PR or issue that should block the release until it gets resolved label Jun 6, 2021
Copy link
Contributor

@315157973 315157973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hangc0276 hangc0276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui codelipenghui merged commit 4c4b17b into apache:master Jun 6, 2021
@codelipenghui codelipenghui deleted the penghui/set-version-presto branch June 6, 2021 06:13
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
Since the apache#10728
make the pulsar sql module to be a child of Pulsar main project
we don't need to run the specific set-version for the presto-distribution
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
Since the apache#10728
make the pulsar sql module to be a child of Pulsar main project
we don't need to run the specific set-version for the presto-distribution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/blocker Indicate the PR or issue that should block the release until it gets resolved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure when using src/set-project-version.sh: Project version is inherited from parent.

5 participants