Skip to content

Replace batchIndexAcknowledgeEnable to acknowledgmentAtBatchIndexLevelEnabled#10844

Merged
wolfstudy merged 1 commit intoapache:masterfrom
wolfstudy:xiaolong/fix-batch-docs
Jun 7, 2021
Merged

Replace batchIndexAcknowledgeEnable to acknowledgmentAtBatchIndexLevelEnabled#10844
wolfstudy merged 1 commit intoapache:masterfrom
wolfstudy:xiaolong/fix-batch-docs

Conversation

@wolfstudy
Copy link
Member

Signed-off-by: xiaolongran xiaolongran@tencent.com

Fixes #10821

Motivation

As #10821 said, It seems that batchIndexAcknowledgeEnable and acknowledgmentAtBatchIndexLevelEnabled are confused in the documentation.

Modifications

Replace batchIndexAcknowledgeEnable to acknowledgmentAtBatchIndexLevelEnabled

…lEnabled

Signed-off-by: xiaolongran <xiaolongran@tencent.com>
@wolfstudy wolfstudy added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jun 7, 2021
@wolfstudy wolfstudy added this to the 2.8.0 milestone Jun 7, 2021
@wolfstudy wolfstudy self-assigned this Jun 7, 2021
@wolfstudy
Copy link
Member Author

Ping @codelipenghui @Anonymitaet PTAL thanks.

Copy link
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve from the language perspective.

@wolfstudy wolfstudy merged commit 02d5eb3 into apache:master Jun 7, 2021
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
…lEnabled (apache#10844)

Signed-off-by: xiaolongran <xiaolongran@tencent.com>

Fixes apache#10821 

### Motivation

As apache#10821 said, It seems that `batchIndexAcknowledgeEnable` and `acknowledgmentAtBatchIndexLevelEnabled` are confused in the documentation.

### Modifications

Replace `batchIndexAcknowledgeEnable` to `acknowledgmentAtBatchIndexLevelEnabled`
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
…lEnabled (apache#10844)

Signed-off-by: xiaolongran <xiaolongran@tencent.com>

Fixes apache#10821 

### Motivation

As apache#10821 said, It seems that `batchIndexAcknowledgeEnable` and `acknowledgmentAtBatchIndexLevelEnabled` are confused in the documentation.

### Modifications

Replace `batchIndexAcknowledgeEnable` to `acknowledgmentAtBatchIndexLevelEnabled`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] Need clarification around batch indexing configs

3 participants