fix failed to generate prometheus stats for transaction#10899
fix failed to generate prometheus stats for transaction#10899xuesongxs wants to merge 5 commits intoapache:masterfrom xuesongxs:transactions-metrics
Conversation
update code
update code
update code
|
thank you @xuesongxs |
This feature has been included in ManagedLedgerMetricsTest.testManagedLedgerMetrics(). |
|
If you change some line in the code, this should be an effect on tests:
it looks strange to me that you are changing a constant and there is no change in the tests. |
|
@eolivelli I've added unit test case. |
|
@gaoran10 @congbobo184 @codelipenghui Can you review this PR? |
congbobo184
left a comment
There was a problem hiding this comment.
@xuesongxs in 2.8.0 transaction will not generate wrong managedLedger name, so we shouldn't need to fix this problem.
|
The pr had no activity for 30 days, mark with Stale label. |
|
@xuesongxs:Thanks for your contribution. For this PR, do we need to update docs? |
fix #10898
modify regular expression.