[ Tests ] Fixed flaky test createResourceGroup#11117
Closed
mattisonchao wants to merge 1 commit intoapache:masterfrom
mattisonchao:fixed_flaky_test_11105
Closed
[ Tests ] Fixed flaky test createResourceGroup#11117mattisonchao wants to merge 1 commit intoapache:masterfrom mattisonchao:fixed_flaky_test_11105
mattisonchao wants to merge 1 commit intoapache:masterfrom
mattisonchao:fixed_flaky_test_11105
Conversation
Contributor
|
@mattisonchao If the tests failed frequently, I'm not sure if increase the timeout to 30s can fix the problem. Because 10s looks enough for the HTTP request since we do not have a very expensive operation. Have you checked the thread dump or others? make sure the issue is not caused by the deadlock. |
Member
Author
Ok, I will check out it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11105 , #11096
Master Issue: #11105 , #11096
Motivation
#11048 fix this test failed with Awaitility.await().until to wait for asyncPutRequest, however, the default wait timeout is 10s, if asyncPutRequest reaches 10s, it will also run fail.
Modifications