Skip to content

[feat][website] add local debugging tools shell for website#11160

Merged
tuteng merged 4 commits intoapache:masterfrom
urfreespace:feature/local-docker-debug-website
Jul 1, 2021
Merged

[feat][website] add local debugging tools shell for website#11160
tuteng merged 4 commits intoapache:masterfrom
urfreespace:feature/local-docker-debug-website

Conversation

@urfreespace
Copy link
Member

Currently, website construction test is not very convenient, you need to merge branches to see the effect, in order to facilitate local testing, I added this tool script, after building the website, you can execute sh debug-site.sh locally, you can access the latest build locally Website

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (no)

Signed-off-by: LiLi <urfreespace@gmail.com>
Copy link
Member

@tuteng tuteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add introduction in readme file

@urfreespace urfreespace changed the title feat: add local debugging tools shell for website [feat][website] add local debugging tools shell for website Jun 30, 2021
@urfreespace
Copy link
Member Author

LGTM, please add introduction in readme file

@tuteng done, PTAL, thanks

@urfreespace urfreespace requested a review from tuteng June 30, 2021 03:43
@sijie sijie added this to the 2.9.0 milestone Jun 30, 2021
@Anonymitaet
Copy link
Member

As we discussed just now, we do not add the instructions to READ.ME now since there might be a better and simpler way to handle this. I'll preview the local changes and need help from @urfreespace later, and then write down the instructions.

@Anonymitaet
Copy link
Member

@tuteng could you please help review this PR? Thanks

@tuteng tuteng merged commit e8b773e into apache:master Jul 1, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
…1160)

Currently, website construction test is not very convenient, you need to merge branches to see the effect, in order to facilitate local testing, I added this tool script, after building the website, you can execute `sh debug-site.sh` locally, you can access the latest build locally Website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants