PIP-45: Removed direct ZK access from BrokerService#11267
Merged
merlimat merged 16 commits intoapache:masterfrom Jul 15, 2021
Merged
PIP-45: Removed direct ZK access from BrokerService#11267merlimat merged 16 commits intoapache:masterfrom
merlimat merged 16 commits intoapache:masterfrom
Conversation
merlimat
added
the
type/enhancement
sijie
approved these changes
Jul 8, 2021
Member
|
@merlimat thanks for your contribution. For this PR, do we need to update docs? |
eolivelli
approved these changes
Jul 9, 2021
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Overall it looks good to me.
CI is failing, there is probably some little fine tuning to be done on the code
jerrypeng
approved these changes
Jul 9, 2021
merlimat
force-pushed
the
pip-45-broker-service
branch
from
a3c62bc to
c84c5d6
Compare
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
* PIP-45: Removed direct ZK access from BrokerService * Corrected dynamicConfigurationCache to read from local metadata store * Fixed test issues * Fixed checkstyle * Removed unused import * Fixed cache invalidation issues * Avoid blocking restart of load manager from metdata store listener thread * checkMaxTopicsPerNamespace() must be asynchrounous * Fixed checkstyle * Fixed mocked tests * Fixed AdminApiTest.testInvalidDynamicConfigContentInZK() * Also fixed in V1_AdminApiTest * Fixed mocks in PersistentTopicTest * Fixed PersistentSubscriptionTest * Fixed PersistentDispatcherFailoverConsumerTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Refactored
BrokerServiceto useMetadataStore