Allow to config Sasl configs in Kafka sink.#11422
Merged
BewareMyPower merged 2 commits intoapache:masterfrom Jul 27, 2021
hezhangjian:master
Merged
Allow to config Sasl configs in Kafka sink.#11422BewareMyPower merged 2 commits intoapache:masterfrom hezhangjian:master
BewareMyPower merged 2 commits intoapache:masterfrom
hezhangjian:master
Conversation
BewareMyPower
requested changes
Jul 23, 2021
Contributor
BewareMyPower
left a comment
BewareMyPower
left a comment
There was a problem hiding this comment.
Please add tests for these configs. You can modify the existed kafkaSinkConfig.yaml under resource directory.
Contributor
|
for the tests simple unit tests around |
eolivelli
reviewed
Jul 23, 2021
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
The patch overall looks good to me
please add the tests as @BewareMyPower commented
BewareMyPower
approved these changes
Jul 25, 2021
murong00
approved these changes
Jul 26, 2021
1 task
codelipenghui
pushed a commit
that referenced
this pull request
Dec 15, 2021
related to #11422 ### Motivation Allow pulsar io to consume messages to sasl kafka cluster. ### Modifications Add several kafka sasl configs, make them configable.
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
related to apache#11422 ### Motivation Allow pulsar io to consume messages to sasl kafka cluster. ### Modifications Add several kafka sasl configs, make them configable.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation Allow pulsar io to push messages to sasl kafka cluster. ### Modifications Add several kafka sasl configs, make them configable. ### Documentation I think the pulsar-io can automatically generate the doc for added fields. So we don't need add any docs.
4 tasks
momo-jun
added
doc-complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Allow pulsar io to push messages to sasl kafka cluster.
Modifications
Add several kafka sasl configs, make them configable.
Documentation
I think the pulsar-io can automatically generate the doc for added fields. So we don't need add any docs.