Skip to content

[docs] [ISSUE 8262] [ISSUE 7625] Update request body description of sinks REST APIs#11716

Closed
sijia-w wants to merge 1 commit intoapache:masterfrom
sijia-w:fix-8262
Closed

[docs] [ISSUE 8262] [ISSUE 7625] Update request body description of sinks REST APIs#11716
sijia-w wants to merge 1 commit intoapache:masterfrom
sijia-w:fix-8262

Conversation

@sijia-w
Copy link
Contributor

@sijia-w sijia-w commented Aug 19, 2021

Fixes #8262
Fixes #7625

Thanks @BewareMyPower for providing the code.

@sijia-w
Copy link
Contributor Author

sijia-w commented Aug 19, 2021

@tuteng @BewareMyPower Can you please help review the changes? Many thanks.

@BewareMyPower BewareMyPower added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Aug 19, 2021
@BewareMyPower
Copy link
Contributor

LGTM, but I think it's better to upload the preview image.

@Anonymitaet Anonymitaet added this to the 2.9.0 milestone Aug 20, 2021
@sijia-w
Copy link
Contributor Author

sijia-w commented Aug 20, 2021

I'll upload the preview soon.

@sijia-w
Copy link
Contributor Author

sijia-w commented Sep 3, 2021

@BewareMyPower In the preview page, only the first value in the screenshot is displayed. Further modification is needed.
image
image

Many thanks to @tuteng @urfreespace for their help in previewing the changes.

@eolivelli eolivelli modified the milestones: 2.9.0, 2.10.0 Oct 6, 2021
@Anonymitaet
Copy link
Member

Discussed w/ @sijia-w:

Currently, the REST API sink page shows the content in the red box:
image

But if we merge this PR, it only shows the content in the blue box, which hides many existing contents:
image

This is a display issue, so we are waiting for @tuteng's solution.

@codelipenghui
Copy link
Contributor

The pr had no activity for 30 days, mark with Stale label.

@tisonkun
Copy link
Member

tisonkun commented Dec 6, 2022

Closed as stale. It seems a framework issue that all form data param's name are 'body'.

@tisonkun tisonkun closed this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. lifecycle/stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The REST API to create source is not correct [docs] request body description of sinks REST APIs is wrong

6 participants

Comments