Skip to content

[ PIP-82] [pulsar-broker] Fix a couple of issues#11732

Merged
cckellogg merged 1 commit intoapache:masterfrom
bharanic-dev:rg-bug-fixes
Aug 24, 2021
Merged

[ PIP-82] [pulsar-broker] Fix a couple of issues#11732
cckellogg merged 1 commit intoapache:masterfrom
bharanic-dev:rg-bug-fixes

Conversation

@bharanic-dev
Copy link
Contributor

Modifications

  • Handle ChildrenChanged metadata-store event.
  • Update the publish rate limiter correctly.

Verifying this change

  • Make sure that the change passes the CI checks.
  • verified via manual testing

Documentation

No documentation impact.

@bharanic-dev
Copy link
Contributor Author

@jerrypeng PTAL when you get a chance.

@Anonymitaet Anonymitaet added the doc-not-needed Your PR changes do not impact docs label Aug 23, 2021
@ravi-vaidyanathan
Copy link
Contributor

LGTM

- Update the publish rate limiter correctly.
- invoke ratelimitFunction when the rate limiter is closed.
@bharanic-dev
Copy link
Contributor Author

/pulsarbot run-failure-checks

2 similar comments
@bharanic-dev
Copy link
Contributor Author

/pulsarbot run-failure-checks

@bharanic-dev
Copy link
Contributor Author

/pulsarbot run-failure-checks

@cckellogg cckellogg merged commit 7b992cf into apache:master Aug 24, 2021
bharanic-dev added a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
- Update the publish rate limiter correctly.
- invoke ratelimitFunction when the rate limiter is closed.

Co-authored-by: Bharani Chadalavada <bchadalavada@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants