Fixed ResourceLockTest.revalidateLockOnDifferentSession()#11885
Merged
lhotari merged 3 commits intoapache:masterfrom Sep 1, 2021
Merged
Fixed ResourceLockTest.revalidateLockOnDifferentSession()#11885lhotari merged 3 commits intoapache:masterfrom
lhotari merged 3 commits intoapache:masterfrom
Conversation
lhotari
approved these changes
Sep 1, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
* Fixed ResourceLockTest.revalidateLockOnDifferentSession() * Fixed merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #11690
The main issue in the test is that there are 2
ResourceLockinstances that are competing.RL_1acquires the lockRL_2tries to “steal” the lockRL_2deletes the existing lock,RL_1might get the notification fast and delete the lock afterRL_2did acquire it.That eventually lead in both locks getting expired:
Modification