[Broker] no-persistent topic support terminate

[shibd]

#11834

[congbobo184]

Could you please add a test for it?

[congbobo184]

why not disconnect sub?

[shibd]

Thanks for the review. I think still consumer to drain existing messages in backlog after the termination.Disconnect subscribe will close existing consumers.

May need to call Subscription#close() that no longer accepts new consumers

    @Override
    public CompletableFuture<Void> close() {
        IS_FENCED_UPDATER.set(this, TRUE);
        return CompletableFuture.completedFuture(null);
    }

Do you have any better suggestions?

[congbobo184]

do we need retain existing consumer when non-persistent topic terminate? @gaoran10 @codelipenghui /cc

[gaozhangmin]

I think non-persistent termination should behave like persistent

[shibd]

Could you please add a test for it?

Ok, I'll add it

[merlimat]

The problem with non-persistent topics is that the termination will be lost at the next broker restart or topic failover so it would not make much practical sense.

[shibd]

The problem with non-persistent topics is that the termination will be lost at the next broker restart or topic failover so it would not make much practical sense.

Got it, I will close this pr.