[Broker] Add verification when terminating non-persistent topic#11903
Merged
merlimat merged 3 commits intoapache:masterfrom Sep 6, 2021
Merged
[Broker] Add verification when terminating non-persistent topic#11903merlimat merged 3 commits intoapache:masterfrom
merlimat merged 3 commits intoapache:masterfrom
Conversation
merlimat
reviewed
Sep 2, 2021
Contributor
merlimat
left a comment
merlimat
left a comment
There was a problem hiding this comment.
Looks good. Can you also add a unit test that asserts the response?
Member
Author
|
@merlimat Unit tests have been added. Can you review them for me? |
shibd
changed the title
merlimat
approved these changes
Sep 6, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
…he#11903) * [Broker] Add verification when terminating non-persistent * [Broker] add unit test * code format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11834
Code 406(Not Acceptable) is returned when the non persistent topic is terminated.