Skip to content

[docs] [ISSUE 11805] Add topic lookup metrics#11927

Merged
Anonymitaet merged 3 commits intoapache:masterfrom
sijia-w:fix-11805
Nov 29, 2021
Merged

[docs] [ISSUE 11805] Add topic lookup metrics#11927
Anonymitaet merged 3 commits intoapache:masterfrom
sijia-w:fix-11805

Conversation

@sijia-w
Copy link
Contributor

@sijia-w sijia-w commented Sep 5, 2021

Fixes #11805

@sijia-w
Copy link
Contributor Author

sijia-w commented Sep 5, 2021

@merlimat Can you please explain a bit what metricspulsar_broker_load_manager_bundle_assignment and pulsar_broker_topic_load_pending_request do? By the way, is there a label for lookup metrics in broker.conf file?

@sijia-w
Copy link
Contributor Author

sijia-w commented Sep 6, 2021

/pulsarbot run-failure-checks

@Anonymitaet Anonymitaet added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 7, 2021

private static final Summary selectBrokerForAssignment = Summary.build(
"pulsar_broker_load_manager_bundle_assigment", "-")
"pulsar_broker_load_manager_bundle_assignment", "-")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sijia-w please confirm this change with engineer, thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need to modify this indicator name, because maybe someone use this name somewhere. /cc @merlimat PLTA

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sijia-w, confirmed w/ @gaoran10, please do not modify the code files since they may be referenced somewhere. Can you revert this change?

@sijia-w
Copy link
Contributor Author

sijia-w commented Sep 28, 2021

@merlimat Can you please explain a bit what metricspulsar_broker_load_manager_bundle_assignment and pulsar_broker_topic_load_pending_request do? By the way, is there a label for lookup metrics in broker.conf file? I appreciate your quick response. Many thanks.


private static final Summary selectBrokerForAssignment = Summary.build(
"pulsar_broker_load_manager_bundle_assigment", "-")
"pulsar_broker_load_manager_bundle_assignment", "-")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sijia-w, confirmed w/ @gaoran10, please do not modify the code files since they may be referenced somewhere. Can you revert this change?

@sijia-w
Copy link
Contributor Author

sijia-w commented Nov 27, 2021

@Anonymitaet @gaoran10 Updated. Thank you for your continuous help.

@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Nov 29, 2021
@Anonymitaet Anonymitaet merged commit 5e25184 into apache:master Nov 29, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
* update

* update

* remove changes of the parameter name
@sijia-w sijia-w deleted the fix-11805 branch November 29, 2021 09:50
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
* update

* update

* remove changes of the parameter name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc] missed doc for topic lookup metrics

3 participants