[Broker] Need incrementUnackedMessages when send message to consumer(all subscribe mode)#11998
Closed
shibd wants to merge 1 commit intoapache:masterfrom
Closed
[Broker] Need incrementUnackedMessages when send message to consumer(all subscribe mode)#11998shibd wants to merge 1 commit intoapache:masterfrom
shibd wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@jerrypeng Can you help me review it? |
…all subscribe mode)
MarvinCai
reviewed
Sep 10, 2021
Contributor
MarvinCai
left a comment
There was a problem hiding this comment.
Looks good, can we add/update existing unit test to verify it? Probably at here: https://github.com/apache/pulsar/blob/master/pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/ConsumerStatsTest.java
Member
Author
@MarvinCai Thank you reply. This PR Maybe it's not right, It will change the original design. I'll close the PR, I will discuss this in issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#11979
Modifications
incrementUnackedMessageswhen send message to consumer(all subscribe mode)Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Need to update docs?